Re: Libpq COPY optimization patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: Libpq COPY optimization patch
Date
Msg-id 18495.1138114939@sss.pgh.pa.us
Whole thread Raw
In response to Libpq COPY optimization patch  ("Alon Goldshuv" <agoldshuv@greenplum.com>)
Responses Re: Libpq COPY optimization patch
List pgsql-patches
"Alon Goldshuv" <agoldshuv@greenplum.com> writes:
> Here is a patch against today's code 1/24. As discussed in -hackers
> consumeInput/parse is removed from being called every single time. It's
> still there for only when the data is sent to the server.

This appears to be the exact same patch you sent before.  Did you
test my suggestion of simply removing the PQconsumeInput call?
I see no reason to add it inside the loop.

            regards, tom lane

pgsql-patches by date:

Previous
From: Joachim Wieland
Date:
Subject: Re: [HACKERS] CIDR/INET improvements
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] CIDR/INET improvements