Re: [HACKERS] CIDR/INET improvements - Mailing list pgsql-patches

From Joachim Wieland
Subject Re: [HACKERS] CIDR/INET improvements
Date
Msg-id 20060124092758.GA24797@mcknight.de
Whole thread Raw
In response to Re: [HACKERS] CIDR/INET improvements  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] CIDR/INET improvements
Re: [HACKERS] CIDR/INET improvements
List pgsql-patches
On Mon, Jan 23, 2006 at 11:30:58PM -0500, Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Patch for testing attached.

> This is an utterly bad idea, because it not only doesn't address the
> problem (ie, confusion about whether inet and cidr are distinct types
> or not), but it masks mistakes in that realm by hiding data on output.
> It'll be almost impossible to debug situations where x is different
> from y but they display the same.

FWIW, I append the patch I've done a few weeks ago. It adds an inettocidr
cast function.
I updated it to comply to Bruce's recent "ip_type" -> "ip_is_cidr" change.

Joachim

--
Joachim Wieland                                              joe@mcknight.de
C/ Usandizaga 12 1°B                                           ICQ: 37225940
20002 Donostia / San Sebastian (Spain)                     GPG key available

Attachment

pgsql-patches by date:

Previous
From: Achilleus Mantzios
Date:
Subject: DBMirror.pl performance change
Next
From: Tom Lane
Date:
Subject: Re: Libpq COPY optimization patch