PATCH: CreateComments: use explicit indexing for ``values'' - Mailing list pgsql-hackers

From richhguard-monotone@yahoo.co.uk
Subject PATCH: CreateComments: use explicit indexing for ``values''
Date
Msg-id 183252.96819.qm@web86702.mail.ird.yahoo.com
Whole thread Raw
Responses Re: PATCH: CreateComments: use explicit indexing for ``values''
List pgsql-hackers
Hello,
I'm new to PostgreSQL and git, but having read through the wiki entries such as
http://wiki.postgresql.org/wiki/Submitting_a_Patch,I think I have a patch worthy of submission. 

It's a readability improvement in src/backend/commands/comment.c (CreateComments function), which changes the existing
codefrom incrementing a variable for use as the array index, to use explicit ``values'' instead. 

This has the following benefits

1) The structure of ``values'' is now clear at first glance.
2) ``i'' is then only used for 1 reason; the for loop

The patch is based on "master", and all existing tests pass.

Regards
Richard
Attachment

pgsql-hackers by date:

Previous
From: "Stephen J. Butler"
Date:
Subject: Re: Boolean operators without commutators vs. ALL/ANY
Next
From: Florian Pflug
Date:
Subject: Re: Boolean operators without commutators vs. ALL/ANY