Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co
Date
Msg-id 18276.1461821659@sss.pgh.pa.us
Whole thread Raw
In response to Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes:
> On Wed, Apr 27, 2016 at 10:53 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Now, if VS2015 actually has broken bool-returning V0, the argument for
>> keeping it going becomes a lot weaker.  But at this point I suspect
>> strongly that that's not what happened but rather we've got a faulty
>> bool cast there, which if true is something we need to fix regardless
>> of any considerations about V0.  Would someone please try the experiment
>> requested upthread?

> I just gave it a try. And by using PG_1_BYTE() the tests of
> contrib/seg/ are passing.

Thanks!  Barring objections, I will revert c8e81afc60093b19 tomorrow
and instead fix DatumGetBool.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co
Next
From: Noah Misch
Date:
Subject: Re: GIN data corruption bug(s) in 9.6devel