Re: Continue work on changes to recovery.conf API - Mailing list pgsql-hackers

From Petr Jelinek
Subject Re: Continue work on changes to recovery.conf API
Date
Msg-id 17b4b878-d6ca-3950-935e-c3a539285612@2ndquadrant.com
Whole thread Raw
In response to Re: Continue work on changes to recovery.conf API  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Hi,

On 25/11/2018 21:48, Stephen Frost wrote:
> Greetings,
> 
> On Sun, Nov 25, 2018 at 15:39 Andres Freund <andres@anarazel.de
> <mailto:andres@anarazel.de>> wrote:
> 
>     Hi,
> 
>     On 2018-11-25 13:24:15 -0500, Stephen Frost wrote:
>     > - User performs a backup with pg_basebackup -R
>     > - Replica is then promoted to be a primary
>     > - User performs a backup with pg_basebackup -R on the new primary
>     > - Duplicate entries end up in postgresql.auto.conf.  Ew.
> 
>     Why don't we put recovery entries into postgresql.recovery.conf or such?
>     And overwrite rather than append?
> 
> 
> Sure, I think that’s more or less the same thing..?   Another included
> file, but one specifically for recovery bits.

I think the important part there is overwrite rather than append. Given
that postgresql.auto.conf is used by ALTER SYSTEM, doing overwrites
there is not as straightforward proposition (behaviorally) as doing it
in another included file.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: RHEL 8.0 build
Next
From: Tom Lane
Date:
Subject: Python versions (was Re: RHEL 8.0 build)