Re: tsearch2api .. wrapper for integrated fultext - Mailing list pgsql-patches

From Tom Lane
Subject Re: tsearch2api .. wrapper for integrated fultext
Date
Msg-id 17640.1194718771@sss.pgh.pa.us
Whole thread Raw
In response to Re: tsearch2api .. wrapper for integrated fultext  ("Pavel Stehule" <pavel.stehule@gmail.com>)
Responses Re: tsearch2api .. wrapper for integrated fultext
List pgsql-patches
"Pavel Stehule" <pavel.stehule@gmail.com> writes:
> this is revised version

A couple of thoughts here:

* What is the point of creating stub functions for things that users
won't attempt to call directly, such as opclass support functions and
the old dictionary support functions?  Couldn't we just leave those out
and save some code?

* The WRAPPER_FUNCTION stuff seems unnecessarily inefficient --- can't
we just declare those as LANGUAGE INTERNAL and link the SQL definition
directly to the built-in function?

* The SQL file doesn't create any of the old types (public.tsvector
etc) so it seems still a long ways short of ensuring that an old
dump file can be reloaded.  Maybe I don't understand exactly how you
intend it to interact with the definitions that will be in the dump
file.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Fix for stop words in thesaurus file
Next
From: "Pavel Stehule"
Date:
Subject: Re: tsearch2api .. wrapper for integrated fultext