Re: [PATCHES] snprintf() argument reordering not working - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCHES] snprintf() argument reordering not working
Date
Msg-id 1730.24.211.165.134.1133766150.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: [PATCHES] snprintf() argument reordering not working  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [PATCHES] snprintf() argument reordering not working  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Bruce Momjian said:
>
> OK, a few things.  First, Tom has fixed snprintf.c so it should
> properly process positional parameters now.  Would you first test the
> libintl version of *printf to see if it can process %$ parameters
> (probably by hacking up any language file and testing the printing),
> and then try your patch below to see if it is properly reorders the
> arguments.  If libintl does not reorder properly, but our snprintf.c
> does, would you please generate an appliable patch we can put into
> 8.1.X?  Thanks.
>
> I know I am asking a lot, but you are "the man" on this one.  :-)
>

Since the effect of the configure change I am proposing to reverse was to
force use of the *printf in libintl, don't we already know the answer to
your first question from Nicolai's report?

cheers

andrew




pgsql-hackers by date:

Previous
From: Kevin Brown
Date:
Subject: Re: Reducing relation locking overhead
Next
From: Greg Stark
Date:
Subject: Re: generalizing the planner knobs