Postgres Pro
Downloads
Home   >   mailing lists

Re: Odd behavior of partitioned ALTER TABLE ONLY ... ADD PRIMARY KEY - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Odd behavior of partitioned ALTER TABLE ONLY ... ADD PRIMARY KEY
Date
Msg-id 16954.1555875629@sss.pgh.pa.us
Whole thread Raw
In response to Re: Odd behavior of partitioned ALTER TABLE ONLY ... ADD PRIMARY KEY  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-Apr-21, Tom Lane wrote:
>> ISTM that this is a bug, not a feature: if there's any point at
>> all to saying ONLY in this context, it's that we're not supposed
>> to be doing anything as expensive as adding a new constraint to
>> a child partition.  No?  So I think that this should have failed.

> Hmm, yeah, this is not intentional and I agree that it shouldn't be
> doing this.

>> We need to require the partition(s) to already have attnotnull set.

> Sounds good to me, yes.

> Do you want me to see about this?

It's tied up in the other patch I'm working on, so I can deal with it.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Odd behavior of partitioned ALTER TABLE ONLY ... ADD PRIMARY KEY
Next
From: Tom Lane
Date:
Subject: Re: ALTER TABLE with ADD COLUMN and ADD PRIMARY KEY USING INDEX throws spurious "column contains null values"