Hi Fabian-san,
I reviewed 'pgbench-prp-func/pgbench-prp-func-10.patch'.
On 2018/10/24 12:55, Fabien COELHO wrote:
>
> Hello Hironobu-san,
>
>> In pseudorandom_perm(), `modular_multiply() + (key >> LCG_SHIFT)` may
>> overflow if the result of modular_multiply() is large. Therefore, I've
>> improved it.
>
>> Also, I've simplified Step 5 in modular_multiply().
>
> Attached is a v10, where I have:
> - updated some comments
> - the + cannot overflow because size is taken from a signed int
> and the added value is small thanks to the shift.
> I have put back the simple formula and added a comment about it.
> - added a few test cases, and fix the associated checks
>
I agree your discussion before.
I checked the tests you added in this patch and I confirmed that there
is no problem.
I thinks this patch is fine.
Best regards,
