Re: Review: B-Tree emulation for GIN - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Review: B-Tree emulation for GIN
Date
Msg-id 16643.1233627155@sss.pgh.pa.us
Whole thread Raw
In response to Re: Review: B-Tree emulation for GIN  (Teodor Sigaev <teodor@sigaev.ru>)
Responses Re: Review: B-Tree emulation for GIN  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
Looked at this a bit ... do you think it's really a good idea to remove
the strategy number argument of comparePartial?  The argument given in
the docs for it is that it might be needed to determine when to end the
scan, and that still seems plausible to me.

The description of extractQuery's extra_data parameter seems confusing
too.  AFAICS it is incorrect, or at least misleading, to describe it as
void ** extra_data[]; it is really void ***extra_data, because there is
only one object there not an array.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] GIN improvements
Next
From: Joshua Brindle
Date:
Subject: Re: How to get SE-PostgreSQL acceptable