Re: HOT chain validation in verify_heapam() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: HOT chain validation in verify_heapam()
Date
Msg-id 1650745.1679513221@sss.pgh.pa.us
Whole thread Raw
In response to Re: HOT chain validation in verify_heapam()  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: HOT chain validation in verify_heapam()  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> I have committed this after tidying up a bunch of things in the test
> case file that I found too difficult to understand -- or in some cases
> just incorrect, like:

My animal mamba doesn't like this one bit.

I suspect the reason is that it's big-endian (PPC) and the endianness
hacking in the test is simply wrong:

        syswrite($file,
                 pack("L", $ENDIANNESS eq 'little' ? 0x00010019 : 0x19000100))
            or BAIL_OUT("syswrite failed: $!");

pack's L code should already be performing an endianness swap, so why
are we doing another one in the argument?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Request for comment on setting binary format output per session
Next
From: Daniel Gustafsson
Date:
Subject: Re: On login trigger: take three