Re: MySQL-ism help patch for psql - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: MySQL-ism help patch for psql
Date
Msg-id 162867791001211001s3883aab5va969d3b30fd04bf6@mail.gmail.com
Whole thread Raw
In response to Re: MySQL-ism help patch for psql  (David Christensen <david@endpoint.com>)
List pgsql-hackers
2010/1/21 David Christensen <david@endpoint.com>:
>
> On Jan 21, 2010, at 11:48 AM, Florian Weimer wrote:
>
>> * David Christensen:
>>
>>> Currently, a session will look like the following:
>>>
>>>  machack:machack:5485=# show tables;
>>>  See:
>>>        \d
>>>        or \? for general help with psql commands
>>>  machack:machack:5485=#
>>>
>>> Said formatting looks like it could use some improvement, open to
>>> suggestions, but something on a single line seems more useful.
>>
>> You should at least make clear that this is an error message due to an
>> unsupported command.  The output above looks broken.  Something like
>> this should be okay, I think:
>>
>> ERROR:  unrecognized configuration parameter "tables"
>> NOTICE: use \d to list tables, or \? for general help with psql commands
>>
>> ERROR:  unrecognized configuration parameter "databases"
>> NOTICE: use \l to list databases, or \? for general help with psql
>> commands
>
>
> That's a very good point as far as the visibility is concerned.  Should the
> error messages between the SHOW cases and the others be consistent ("ERROR:
> unsupported command" or similar)?  It's worth noting that this is only in
> the psql client, but we could simulate the ereport output from the server.

I don't think so it is the best idea. I like different message types,
because I able to identify place of error. If it is server or client
error.

Pavel

>
> Regards,
>
> David
> --
> David Christensen
> End Point Corporation
> david@endpoint.com
>
>
>
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Patch: regschema OID type
Next
From: "David E. Wheeler"
Date:
Subject: Re: Patch: regschema OID type