Re: bad logging around broken restore_command - Mailing list pgsql-hackers

From Pavel Borisov
Subject Re: bad logging around broken restore_command
Date
Msg-id 160578524963.18283.1120284634467066674.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: bad logging around broken restore_command  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: bad logging around broken restore_command  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

I decided to add my review to this simple patch.
I applied Fuji's patch and found it perfectly working with installcheck-world passed, code is clean.
As for the feature I agree with Jeff and Fuji that this ENOENT case is worth logging under LOG priority.
I consider the last (Fuji's) patch is now ready to be committed. 

Best regards, 
Pavel Borisov

The new status of this patch is: Ready for Committer

pgsql-hackers by date:

Previous
From: "Hou, Zhijie"
Date:
Subject: RE: Parallel copy
Next
From: Alexey Kondratov
Date:
Subject: Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit