Re: bad logging around broken restore_command - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: bad logging around broken restore_command
Date
Msg-id 1b959eb8-90f2-8e4f-5d18-eb8bd9cd8633@oss.nttdata.com
Whole thread Raw
In response to Re: bad logging around broken restore_command  (Pavel Borisov <pashkin.elfe@gmail.com>)
List pgsql-hackers

On 2020/11/19 20:27, Pavel Borisov wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           not tested
> Documentation:            not tested
> 
> I decided to add my review to this simple patch.
> I applied Fuji's patch and found it perfectly working with installcheck-world passed, code is clean.
> As for the feature I agree with Jeff and Fuji that this ENOENT case is worth logging under LOG priority.
> I consider the last (Fuji's) patch is now ready to be committed.

Thanks for the review! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: don't allocate HashAgg hash tables when running explain only
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Asynchronous Append on postgres_fdw nodes.