Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] plpgsql - additional extra checks - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: [HACKERS] plpgsql - additional extra checks
Date
Msg-id 15e8dd08-4042-9b01-01fd-01f952a4ce33@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] plpgsql - additional extra checks  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: [HACKERS] plpgsql - additional extra checks  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

I'm looking at the updated patch (plpgsql-extra-check-180316.patch), and
this time it applies and builds OK. The one thing I noticed is that the
documentation still uses the old wording for strict_multi_assignement:

WARNING:  Number of evaluated fields does not match expected.
HINT:  strict_multi_assignement check of extra_warnings is active.
WARNING:  Number of evaluated fields does not match expected.
HINT:  strict_multi_assignement check of extra_warnings is active.

This was reworded to "Number of source and target fields in assignment
does not match."

Otherwise it seems fine to me, and I'm tempted to mark it RFC once the
docs get fixed. Stephen, any objections?

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Compile error while building postgresql 10.3
Next
From: Terry Phelps
Date:
Subject: Re: Compile error while building postgresql 10.3