Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()
Date
Msg-id 15986.1461264316@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()  (Kevin Grittner <kgrittn@gmail.com>)
Responses Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()  (Kevin Grittner <kgrittn@gmail.com>)
List pgsql-hackers
Kevin Grittner <kgrittn@gmail.com> writes:
> No joy with that shot in the dark.

> Should I add PGDLLEXPORT to the declaration of
> old_snapshot_threshold.  That doesn't seem to be documented
> anywhere, or have any useful comments; but it looks like it *might*
> be the arcane incantation needed here.

PGDLLIMPORT is what's needed on any backend global variable that's to
be referenced by extensions.  I already pushed a fix before noticing
this thread.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Reducing the size of BufferTag & remodeling forks
Next
From: Tom Lane
Date:
Subject: Re: Wire protocol change