Re: Segfault when restoring -Fd dump on current HEAD - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Segfault when restoring -Fd dump on current HEAD
Date
Msg-id 15816.1551222176@sss.pgh.pa.us
Whole thread Raw
In response to Re: Segfault when restoring -Fd dump on current HEAD  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Hmm, shouldn't we modify sanitize_line so that it returns strdup(hyphen)
> when input is empty and want_hyphen, too?

If this patch is touching the behavior of functions like that, then
it's going in the wrong direction; the need for any such change suggests
strongly that you've failed to restore the old behavior as to which TOC
fields can be null or not.

There might be reason to make such cleanups/improvements separately,
but let's *not* fuzz things up by doing them in the corrective patch.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Segfault when restoring -Fd dump on current HEAD
Next
From: Tomas Vondra
Date:
Subject: Re: [Patch][WiP] Tweaked LRU for shared buffers