Re: Segfault when restoring -Fd dump on current HEAD - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Segfault when restoring -Fd dump on current HEAD
Date
Msg-id 20190226225310.GA4564@alvherre.pgsql
Whole thread Raw
In response to Re: Segfault when restoring -Fd dump on current HEAD  (Dmitry Dolgov <9erthalion6@gmail.com>)
Responses Re: Segfault when restoring -Fd dump on current HEAD
List pgsql-hackers
On 2019-Feb-26, Dmitry Dolgov wrote:

> Yes, it should be rather simple, we can e.g. return to the old less consistent
> NULL handling approach something (like in the attached patch), or replace a NULL
> value with an empty string in WriteToc. Give me a moment, I'll check it out. At
> the same time I would suggest to keep replace_line_endings -> sanitize_line,
> since it doesn't break compatibility.

Hmm, shouldn't we modify sanitize_line so that it returns strdup(hyphen)
when input is empty and want_hyphen, too?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Segfault when restoring -Fd dump on current HEAD
Next
From: Tom Lane
Date:
Subject: Re: Segfault when restoring -Fd dump on current HEAD