Re: Segfault when restoring -Fd dump on current HEAD - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: Segfault when restoring -Fd dump on current HEAD
Date
Msg-id CA+q6zcUUiZLFOiY_gZ4mbsUfCkQOE=ab3hcCW+vXrjKrW-RDPQ@mail.gmail.com
Whole thread Raw
In response to Re: Segfault when restoring -Fd dump on current HEAD  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Segfault when restoring -Fd dump on current HEAD  (Dmitry Dolgov <9erthalion6@gmail.com>)
Re: Segfault when restoring -Fd dump on current HEAD  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: Segfault when restoring -Fd dump on current HEAD  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
> On Tue, Feb 26, 2019 at 6:38 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> Works for me.  With a quick read of the code, it seems to me that it
> is possible to keep compatibility while keeping the simplifications
> around ArchiveEntry()'s refactoring.

Yes, it should be rather simple, we can e.g. return to the old less consistent
NULL handling approach something (like in the attached patch), or replace a NULL
value with an empty string in WriteToc. Give me a moment, I'll check it out. At
the same time I would suggest to keep replace_line_endings -> sanitize_line,
since it doesn't break compatibility.

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: BUG #15589: Due to missing wal, restore ends prematurely andopens database for read/write
Next
From: "Nagaura, Ryohei"
Date:
Subject: RE: Timeout parameters