Re: pg_upgrade: Pass -j down to vacuumdb - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_upgrade: Pass -j down to vacuumdb
Date
Msg-id 15729.1553605759@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_upgrade: Pass -j down to vacuumdb  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-03-25 22:57, Tom Lane wrote:
>> +    fprintf(script, "echo %sYou may wish to add --jobs=N for parallel analyzing.%s\n",
>> +            ECHO_QUOTE, ECHO_QUOTE);

> But then you get that information after you have already started the script.

Yes, but that's already true of all the info that this script prints out.

> I don't find any information about this analyze business on the
> pg_upgrade reference page.  Maybe a discussion there could explain the
> different paths better than making the output script extra complicated.

> Essentially: If you want a slow and gentle analyze, use the supplied
> script.  If you want a fast analyze, use vacuumdb, perhaps with an
> appropriate --jobs option.  Note that pg_upgrade --jobs and vacuumdb
> --jobs are resource-bound in different ways, so the same value might not
> be appropriate for both.

I have no objection to handling it that way (i.e., just as a doc fix).
Or we could do both.

            regards, tom lane


pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Should the docs have a warning about pg_stat_reset()?
Next
From: "Ila B."
Date:
Subject: [GSoC 2019] Proposal: Develop Performance Farm Database and Website