Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_hba.conf - patch to report all parsing errors, and then bail - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_hba.conf - patch to report all parsing errors, and then bail
Date
Msg-id 15584.1236450512@sss.pgh.pa.us
Whole thread Raw
In response to pg_hba.conf - patch to report all parsing errors, and then bail  (Selena Deckelmann <selena@endpoint.com>)
Responses Re: pg_hba.conf - patch to report all parsing errors, and then bail  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Tree view 
Selena Deckelmann <selena@endpoint.com> writes:
> Currently, load_hba() bails on the first parsing error. It would be 
> better for the typo-prone sysadmin if it reported ALL errors, and THEN 
> bailed out.

> This patch implements that behavior.  Tested against 8.4 HEAD this morning.

It sure looks like that's going to try to free new_parsed_lines more
than once.  Shouldn't clean_hba_list be done just once?
        regards, tom lane

pgsql-hackers by date:

Previous
From: Selena Deckelmann
Date:
Subject: pg_hba.conf - patch to report all parsing errors, and then bail
Next
From: Magnus Hagander
Date:
Subject: Re: pg_hba.conf - patch to report all parsing errors, and then bail