Re: pgbench - add minimal stats on initialization - Mailing list pgsql-hackers

From Ibrar Ahmed
Subject Re: pgbench - add minimal stats on initialization
Date
Msg-id 155488787904.1505.2066097895275672647.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: pgbench - add minimal stats on initialization  (Ibrar Ahmed <ibrar.ahmad@gmail.com>)
Responses Re: pgbench - add minimal stats on initialization
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            not tested

Please ignore the last email.

Patch works perfectly and the code is well-written. I have one minor observation that in case of initDropTables you log
"drop"and in case of initCreateTables you log "create table". I think you need to be consistent. And why not "drop
tables"and "create tables"
 

The new status of this patch is: Waiting on Author

pgsql-hackers by date:

Previous
From: Ibrar Ahmed
Date:
Subject: Re: pgbench - add minimal stats on initialization
Next
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Unified logging system for command-line programs