Re: pgbench - add minimal stats on initialization - Mailing list pgsql-hackers

From Ibrar Ahmed
Subject Re: pgbench - add minimal stats on initialization
Date
Msg-id 155488774705.1505.5520644383655619088.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: pgbench - add minimal stats on initialization  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: pgbench - add minimal stats on initialization
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       tested, failed
Spec compliant:           tested, failed
Documentation:            not tested

Patch works perfectly and the code is well-written. I have one minor observation that in case of initDropTables you log
"drop"and in case of initCreateTables you log "create table". I think you need to be consistent. And why not "drop
tables"and "create tables" 

The new status of this patch is: Waiting on Author

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: shared-memory based stats collector
Next
From: Ibrar Ahmed
Date:
Subject: Re: pgbench - add minimal stats on initialization