Re: Tighten error control for OpenTransientFile/CloseTransientFile - Mailing list pgsql-hackers

Overall the patch looks good and according to the previous discussion fulfils its purpose.

It might be worthwhile to also check for errors on close in SaveSlotToPath().

        pgstat_report_wait_end();

        CloseTransientFile(fd);

        /* rename to permanent file, fsync file and directory */
        if (rename(tmppath, path) != 0)