Re: GetNewObjectId question - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GetNewObjectId question
Date
Msg-id 1546622.1670717473@sss.pgh.pa.us
Whole thread Raw
In response to GetNewObjectId question  (Maciek Sakrejda <m.sakrejda@gmail.com>)
Responses Re: GetNewObjectId question  (Michael Paquier <michael@paquier.xyz>)
Re: GetNewObjectId question  (Maciek Sakrejda <m.sakrejda@gmail.com>)
List pgsql-hackers
Maciek Sakrejda <m.sakrejda@gmail.com> writes:
> While browsing through varsup.c, I noticed this comment on GetNewObjectId:
> * Hence, this routine should generally not be used directly.  The only direct
> * callers should be GetNewOidWithIndex() and GetNewRelFileNumber() in
> * catalog/catalog.c.

> But AddRoleMems in user.c appears to also call the function directly:

> /* get an OID for the new row and insert it */
> objectId = GetNewObjectId();

Yeah, that looks like somebody didn't read the memo.
Want to submit a patch?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Ian Lawrence Barwick
Date:
Subject: Re: pg_rewind race condition just after promotion
Next
From: Ian Lawrence Barwick
Date:
Subject: Re: [RFC] Add jit deform_counter