Re: pgbench's expression parsing & negative numbers - Mailing list pgsql-hackers

From Ibrar Ahmed
Subject Re: pgbench's expression parsing & negative numbers
Date
Msg-id 153372592352.1562.15615970772659300837.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: pgbench's expression parsing & negative numbers  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: pgbench's expression parsing & negative numbers  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            not tested

Patch does not apply cleanly on the master branch, anyways I managed that.  Patch work according to specs, and no issue
found.
 
The only minor nit is that you can keep the full comments of function strtoint64

/*
 * If not errorOK, an error message is printed out.
 * If errorOK is true, just return "false" for bad input.
 */

pgsql-hackers by date:

Previous
From: KES
Date:
Subject: Re: Typo in doc or wrong EXCLUDE implementation
Next
From: Thomas Munro
Date:
Subject: Re: partition tree inspection functions