Re: GetTransactionSnapshot() in enum.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GetTransactionSnapshot() in enum.c
Date
Msg-id 15314.1377549081@sss.pgh.pa.us
Whole thread Raw
In response to Re: GetTransactionSnapshot() in enum.c  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: GetTransactionSnapshot() in enum.c  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Aug 19, 2013 at 1:41 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> BTW, I notice that the MVCC-catalog-scans patch summarily asserts that
>> RenumberEnumType no longer poses any concurrency hazards.  I doubt that's
>> true: isn't it still possible that pg_enum rows acquired through the
>> syscaches will have inconsistent enumsortorder values, if they were
>> read at different times?  If you want to examine enumsortorder, you really
>> need to be comparing rows you know were read with the *same* snapshot.

> Good point, I missed that.  Here's a proposed comment patch.

Looks sane to me.
        regards, tom lane



pgsql-hackers by date:

Previous
From: David Fetter
Date:
Subject: Re: pg_restore multiple --function options
Next
From: Tom Lane
Date:
Subject: Re: pg_system_identifier()