Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)
Date
Msg-id 1454.1495046671@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.)  (Andres Freund <andres@anarazel.de>)
Responses Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2017-05-17 13:35:22 -0400, Tom Lane wrote:
>> Not sure about actually incorporating it into our repo.  Doing so would
>> make it easier for people to use, for sure, and the license seems to be
>> regular 3-clause BSD, so that angle is OK.  But do we want to be carrying
>> around another 150K of source code?

> 150k? Isn't it like 3-4k?

The version we're using now is

$ tar xfz ~/archive/pg_bsd_indent-1.3.tar.gz 
$ wc pg_bsd_indent/*   38    122    928 pg_bsd_indent/Makefile  107    831   4835 pg_bsd_indent/README  508   1743
11988pg_bsd_indent/args.c  569   2727  14732 pg_bsd_indent/indent.1 1288   5677  37815 pg_bsd_indent/indent.c  101
671  4251 pg_bsd_indent/indent_codes.h  367   2376  15206 pg_bsd_indent/indent_globs.h  685   2781  18045
pg_bsd_indent/io.c 634   2709  17017 pg_bsd_indent/lexi.c  306   1133   8019 pg_bsd_indent/netbsd.patch  366   1659
10953pg_bsd_indent/parse.c  478   2427  15199 pg_bsd_indent/pr_comment.c 5447  24856 158988 total
 

(Note I was counting bytes not LOC.)

I've not looked at FreeBSD's version, but I'll bet a nickel it's bigger.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] fix hard-coded index in make_partition_op_expr
Next
From: Andres Freund
Date:
Subject: Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.)