Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.) - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.)
Date
Msg-id 20170517185041.2q56pefclhqvmfl6@alap3.anarazel.de
Whole thread Raw
In response to Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2017-05-17 14:44:31 -0400, Tom Lane wrote:
> $ tar xfz ~/archive/pg_bsd_indent-1.3.tar.gz 
> $ wc pg_bsd_indent/*
>     38    122    928 pg_bsd_indent/Makefile
>    107    831   4835 pg_bsd_indent/README
>    508   1743  11988 pg_bsd_indent/args.c
>    569   2727  14732 pg_bsd_indent/indent.1
>   1288   5677  37815 pg_bsd_indent/indent.c
>    101    671   4251 pg_bsd_indent/indent_codes.h
>    367   2376  15206 pg_bsd_indent/indent_globs.h
>    685   2781  18045 pg_bsd_indent/io.c
>    634   2709  17017 pg_bsd_indent/lexi.c
>    306   1133   8019 pg_bsd_indent/netbsd.patch
>    366   1659  10953 pg_bsd_indent/parse.c
>    478   2427  15199 pg_bsd_indent/pr_comment.c
>   5447  24856 158988 total


> (Note I was counting bytes not LOC.)

Ah, that explains that ;)


> I've not looked at FreeBSD's version, but I'll bet a nickel it's bigger.

Not really, even counting the added tests.
 1275   5805  38674 freebsd_indent/indent.c  595   2867  15020 freebsd_indent/indent.1    9     25    240
freebsd_indent/Makefile 342   1451   9587 freebsd_indent/parse.c  343   2234  14637 freebsd_indent/indent_globs.h  356
1771  11311 freebsd_indent/pr_comment.c  522   2190  14063 freebsd_indent/io.c   18     48    361
freebsd_indent/Makefile.depend   7     18     89 freebsd_indent/tests/cppelsecom.0.stdout    0      1      5
freebsd_indent/tests/nsac.pro  52    173   1093 freebsd_indent/tests/comments.0    6     11     54
freebsd_indent/tests/nsac.0.stdout   0      1      4 freebsd_indent/tests/label.pro    8     20     96
freebsd_indent/tests/float.0.stdout   0      1      4 freebsd_indent/tests/sac.pro    9     20    127
freebsd_indent/tests/surplusbad.0.stdout  60    177   1127 freebsd_indent/tests/comments.0.stdout    0      1     22
freebsd_indent/tests/types_from_file.pro   7     18     86 freebsd_indent/tests/cppelsecom.0   30     46    284
freebsd_indent/tests/f_decls.0.stdout  23     50    571 freebsd_indent/tests/parens.0   14     35    246
freebsd_indent/tests/list_head.0.stdout  73    147    900 freebsd_indent/tests/declarations.0.stdout   16     35    242
freebsd_indent/tests/list_head.0  21     51    214 freebsd_indent/tests/struct.0    6     20     95
freebsd_indent/tests/float.0  42    118    555 freebsd_indent/tests/elsecomment.0   13     31    134
freebsd_indent/tests/label.0  23     50    558 freebsd_indent/tests/parens.0.stdout   27     51    286
freebsd_indent/tests/f_decls.0   9     20    125 freebsd_indent/tests/surplusbad.0    9     31    208
freebsd_indent/tests/binary.0   4     12     54 freebsd_indent/tests/nsac.0    0      1      4
freebsd_indent/tests/surplusbad.pro   4     12     54 freebsd_indent/tests/sac.0    1      3     15
freebsd_indent/tests/parens.pro   5     19     95 freebsd_indent/tests/offsetof.0    6     17    102
freebsd_indent/tests/wchar.0.stdout  47    118    578 freebsd_indent/tests/elsecomment.0.stdout   79    143    850
freebsd_indent/tests/declarations.0   3     14     60 freebsd_indent/tests/types_from_file.0    0      1      3
freebsd_indent/tests/elsecomment.pro   6     12     55 freebsd_indent/tests/sac.0.stdout    1      2      3
freebsd_indent/tests/types_from_file.list   6     17     94 freebsd_indent/tests/wchar.0    3     15     62
freebsd_indent/tests/types_from_file.0.stdout  11     31    209 freebsd_indent/tests/binary.0.stdout    7     19     96
freebsd_indent/tests/offsetof.0.stdout  14     31    207 freebsd_indent/tests/label.0.stdout    0      1      4
freebsd_indent/tests/comments.pro  23     47    215 freebsd_indent/tests/struct.0.stdout  100    818   4720
freebsd_indent/README  51    300   2082 freebsd_indent/indent.h  351   1415  10848 freebsd_indent/args.c   75    425
2740freebsd_indent/indent_codes.h  654   2577  17238 freebsd_indent/lexi.c 5366  23567 151406 total
 


- Andres



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)
Next
From: Jeevan Ladhe
Date:
Subject: Re: [HACKERS] fix hard-coded index in make_partition_op_expr