Re: [HACKERS] GCC 7 warnings - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] GCC 7 warnings
Date
Msg-id 14447.1491841559@sss.pgh.pa.us
Whole thread Raw
In response to [HACKERS] GCC 7 warnings  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] GCC 7 warnings  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> Possible fixes:

> a) Ignore, hoping GCC will change before final release. (unlikely at
> this point)

> b) Add compiler option to disable this particular warning, worry about
> it later.  (Might be an option for backpatching.)

> c) Expand the target buffer sizes until the warning goes away.  (Sample
> patch attached.)

> d) Replace most of the problematic code with psprintf() and dynamically
> sized buffers.

+1 for (c) as you have it.  Later we might think about selectively
doing (d), but it seems like more work for probably not much benefit.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Adding lfirst_node (was Re: [HACKERS] [sqlsmith] Planner crashon foreign table join)
Next
From: Fujii Masao
Date:
Subject: Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf