Re: [HACKERS] GCC 7 warnings - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [HACKERS] GCC 7 warnings
Date
Msg-id 20170411175708.coshtfzejgaqhar2@alvherre.pgsql
Whole thread Raw
In response to Re: [HACKERS] GCC 7 warnings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] GCC 7 warnings  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:

> > d) Replace most of the problematic code with psprintf() and dynamically
> > sized buffers.
> 
> +1 for (c) as you have it.  Later we might think about selectively
> doing (d), but it seems like more work for probably not much benefit.

Yeah -- also it's possible some of these code paths must not attempt to
palloc() for robustness reasons.  I would go for c) only for now, and
only try d) for very specific cases where there are no such concerns.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Possible problem in Custom Scan API
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] TAP tests take a long time