Re: ERROR messages in VACUUM's PARALLEL option - Mailing list pgsql-hackers

From Tom Lane
Subject Re: ERROR messages in VACUUM's PARALLEL option
Date
Msg-id 141969.1681221490@sss.pgh.pa.us
Whole thread Raw
In response to ERROR messages in VACUUM's PARALLEL option  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: ERROR messages in VACUUM's PARALLEL option  (Melanie Plageman <melanieplageman@gmail.com>)
Re: ERROR messages in VACUUM's PARALLEL option  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> Over in [1], Horiguchisan mentioned a few things about VACUUM's new
> BUFFER_USAGE_LIMIT option.

> 1) buffer_usage_limit in the ERROR messages should be consistently in uppercase.

FWIW, I think this is exactly backward, and so is whatever code you
based this on.  Our usual habit is to write GUC names and suchlike
in lower case in error messages.  Add double quotes if you feel you
want to set them off from the surrounding text.  Here's a typical
example of longstanding style:

regression=# set max_parallel_workers_per_gather to -1;
ERROR:  -1 is outside the valid range for parameter "max_parallel_workers_per_gather" (0 .. 1024)

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: When to drop src/tools/msvc support
Next
From: "Jonathan S. Katz"
Date:
Subject: Re: When to drop src/tools/msvc support