Re: pgsql: Check for GiST index tuples that don't fit on a page. - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql: Check for GiST index tuples that don't fit on a page.
Date
Msg-id 1412642021.30485.17.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: pgsql: Check for GiST index tuples that don't fit on a page.  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-committers
On Sun, 2014-10-05 at 10:06 +0300, Heikki Linnakangas wrote:
> Hmm. For this particular case, it would straightforward to add a step to
> the buildfarm script to do "grep -r '%z' src". It might turn up false
> positives, if there's a %z in comments or such, but it shouldn't be much
> effort to maintain a list of exceptions to filter out the false positives.

The problem in this case was that a change was backpatched that doesn't
always work in back branches, but works fine in master.  The check you
describe would only have worked if somehow we'd have added it at the
time %z support was added to master, with tremendous foresight.  Plus,
you don't really want to get into the habit of backpatching more ways
the build could fail in stable branches.




pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Check for GiST index tuples that don't fit on a page.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix array overrun in ecpg's version of ParseDateTime().