Re: [pgsql-hackers-win32] explain analyze timings - Mailing list pgsql-patches

From Tom Lane
Subject Re: [pgsql-hackers-win32] explain analyze timings
Date
Msg-id 13968.1111357820@sss.pgh.pa.us
Whole thread Raw
In response to Re: [pgsql-hackers-win32] explain analyze timings  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-patches
"Magnus Hagander" <mha@sollentuna.net> writes:
> Here is a second attempt, hope it's closer to what you expected.

Better --- patch applied with some minor editorialization.

> I still left two #ifdefs in there, for the addition and subtraction of
> timeval:s specifically. They could be made functions/macros too, just
> not sure if it's worth it.

Probably not.  What bothers me more is the unconditional use of a
static inline function; but IIRC we are only supporting gcc-based builds
on Windows, so that probably isn't worth fixing either.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: [pgsql-hackers-win32] explain analyze timings
Next
From: Neil Conway
Date:
Subject: Re: [patch 0/6] pgcrypto update