Re: Fw: [COMMITTERS] pgsql: Fix blatantly broken record_image_cmp() logic for pass-by-value - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: Fw: [COMMITTERS] pgsql: Fix blatantly broken record_image_cmp() logic for pass-by-value
Date
Msg-id 1384040072.74454.YahooMailNeo@web162903.mail.bf1.yahoo.com
Whole thread Raw
In response to Fw: [COMMITTERS] pgsql: Fix blatantly broken record_image_cmp() logic for pass-by-value  (Kevin Grittner <kgrittn@ymail.com>)
List pgsql-hackers
Kevin Grittner <kgrittn@ymail.com> wrote:

>> I distilled it down to the simplest case I could find which
>> failed to produce the warning; attached. Do you agree that it is
>> a compiler bug that this generates no warning?

>> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
>> -Wdeclaration-after-statement -Wendif-labels
>> -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
>> -fwrapv -fexcess-precision=standard -g -D_GNU_SOURCE -c -o
>> warning_test.o warning_test.c -MMD -MP

The actual test case I sent for gcc is what is attached here.
Sorry for attaching the wrong file before.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: logical changeset generation v6.5
Next
From: Robert Haas
Date:
Subject: Re: Race condition in b-tree page deletion