Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch
Date
Msg-id 13737.1190849583@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-patches
Gregory Stark <stark@enterprisedb.com> writes:
> [ revised version of tuptoaster-fixup.patch ]

I've applied most of this.  I didn't like the hardwired assumption about
minimum size to compress, and anyway you had put it in a place where it
broke the intended behavior for SET STORAGE PLAIN.  I replaced it with
just a test to save palloc/pfree overhead in toast_compress_datum, which
has at least got knowledge of which PGLZ strategy is being used.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Minor recovery changes
Next
From: "Hiroshi Saito"
Date:
Subject: Re: Warning is adjusted of pgbench.