Re: Document and/or remove unreachable code in tuptoaster.c from varvarlena patch - Mailing list pgsql-hackers

From Gregory Stark
Subject Re: Document and/or remove unreachable code in tuptoaster.c from varvarlena patch
Date
Msg-id 871wetpxzy.fsf@oxford.xeocode.com
Whole thread Raw
In response to Document and/or remove unreachable code in tuptoaster.c from varvarlena patch  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
Sorry, meant to send the previous message to pgsql-patches.

Here's a version cut using cvs diff so it's usable with -p0

I added one more fixup. There was a silly test in toast_fetch_datum_slice()
which handled compressed datums. Returning a slice of a compressed datum is
nonsensical with toast since the resulting datum would be useless. I also
added an assertion in this function that the datum is external before we treat
it as a toast_pointer.

(Incidentally, I did eventually manage to construct a case to reach all the pfrees.)




--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [PATCHES] allow CSV quote in NULL
Next
From: Stephen Frost
Date:
Subject: Re: [PATCHES] allow CSV quote in NULL