Re: compiler warnings on the buildfarm - Mailing list pgsql-hackers

From Tom Lane
Subject Re: compiler warnings on the buildfarm
Date
Msg-id 13577.1184282141@sss.pgh.pa.us
Whole thread Raw
In response to Re: compiler warnings on the buildfarm  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> Somebody needs to figure out whether we are supposed to be using
>> pgsymlink on Cygwin.

> According to port.h:
>  *  Cygwin has its own symlinks which work on Win95/98/ME where
>  *  junction points don't, so use it instead.  We have no way of
>  *  knowing what type of system Cygwin binaries will be run on.

> So it looks like we should not be using pgsymlink() on Cygwin, unless we 
> declare that these platforms under Cygwin are no longer supported.

Fair enough; Cygwin is kind of a legacy port at this point anyway, so
we shouldn't be doing anything to reduce its backwards compatibility.

I'll fix dirmod.c to match port.h.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: compiler warnings on the buildfarm
Next
From: Tom Lane
Date:
Subject: Re: compiler warnings on the buildfarm