Postgres Pro
Downloads
Home   >   mailing lists

Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name
Date
Msg-id 13325.1549838359@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #15572: Misleading message reported by "Drop functionoperation" on DB with functions having same name  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: BUG #15572: Misleading message reported by "Drop functionoperation" on DB with functions having same name
List pgsql-bugs
Tree view 
David Rowley <david.rowley@2ndquadrant.com> writes:
> Updated patch attached again.  This time due to a newly added call to
> LookupFuncName()  in 1fb57af92.

Hmm ... I'd not looked at this before, but now that I do, the new API
for LookupFuncName seems mighty confused, or at least confusingly
documented.  It's not clear what the combinations of the flags actually
do, or why you'd want to use them.

I wonder whether you'd be better off replacing the two bools with an
enum, or something like that.

            regards, tom lane

pgsql-bugs by date:

Previous
From: David Rowley
Date:
Subject: Re: BUG #15572: Misleading message reported by "Drop functionoperation" on DB with functions having same name
Next
From: "Saul, Jean Paolo"
Date:
Subject: Re: BUG #15609: synchronous_commit=off insert performance regressionwith secondary indexes