Re: review of: collation for (expr) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: review of: collation for (expr)
Date
Msg-id 1330716006.11007.6.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: review of: collation for (expr)  (Jaime Casanova <jaime@2ndquadrant.com>)
List pgsql-hackers
On tor, 2012-03-01 at 20:30 -0500, Jaime Casanova wrote:
> besides a clash in the oid and the value of leakproof missing in the
> pg_proc entry, everything works fine.

Fixed.

> The only thing is that i don't see a reason for these includes in
> src/backend/utils/adt/misc.c:
> 
> + #include "nodes/nodeFuncs.h"
> + #include "utils/lsyscache.h"

lsyscache.h is necessary for type_is_collatable(), but the other was
probably left over from a previous attempt.

Committed with these changes.




pgsql-hackers by date:

Previous
From: Daniel Farina
Date:
Subject: Re: Runtime SHAREDIR for testing CREATE EXTENSION
Next
From: Robert Haas
Date:
Subject: Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)