Re: Large C files - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Large C files
Date
Msg-id 1319053053-sup-7721@alvh.no-ip.org
Whole thread Raw
In response to Re: Large C files  (David Fetter <david@fetter.org>)
List pgsql-hackers
Excerpts from David Fetter's message of lun oct 17 03:00:19 -0300 2011:
> On Fri, Oct 14, 2011 at 07:36:32PM +0100, Peter Geoghegan wrote:
> > This evening, David Fetter described a problem to me that he was
> > having building the Twitter FDW. It transpired that it was down to its
> > dependence on an #include that was recently judged to be
> > redundant.This seems like another reason to avoid using pgrminclude -
> > even if we can be certain that the #includes are redundant within
> > Postgres, we cannot be sure that they are redundant in third party
> > code.
> 
> Perhaps something that tested some third-party code
> automatically...say, doesn't the new buildfarm stuff allow running
> some arbitrary code?

I think you could run your own buildfarm member and add whatever "steps"
you wanted (we have one building JDBC).  I'm not sure that we want that
though -- it'd start polluting the greenness of our buildfarm with
failures from code outside of our control.

I mean, if the third party code fails to compile, surely it's the third
party devs that care.

I fail to see why this is such a big deal.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Kohei KaiGai
Date:
Subject: Re: [v9.2] DROP statement reworks
Next
From: Florian Pflug
Date:
Subject: Re: synchronized snapshots