Re: improve ssl error code, 2147483650 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: improve ssl error code, 2147483650
Date
Msg-id 1318844.1719325318@sss.pgh.pa.us
Whole thread Raw
In response to Re: improve ssl error code, 2147483650  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Peter Eisentraut <peter@eisentraut.org> writes:
> On 21.06.24 16:53, Tom Lane wrote:
>> Most of libpq gets at strerror_r via SOCK_STRERROR for Windows
>> portability.  Is that relevant here?

> Looking inside the OpenSSL code, it makes no efforts to translate 
> between winsock error codes and standard error codes, so I don't think 
> our workaround/replacement code needs to do that either.

Fair enough.

> Btw., our source code comments say something like 
> "ERR_reason_error_string randomly refuses to map system errno values." 
> The reason it doesn't is exactly that it can't do it while maintaining 
> thread-safety.

Ah.  Do you want to improve that comment while you're at it?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Dave Cramer
Date:
Subject: Re: Direct SSL connection and ALPN loose ends
Next
From: Tom Lane
Date:
Subject: Re: add a new explain option including_query for include query string inside the json plan output