Re: improve ssl error code, 2147483650 - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: improve ssl error code, 2147483650
Date
Msg-id 337a869d-9d99-40a1-aef1-c70806498768@eisentraut.org
Whole thread Raw
In response to Re: improve ssl error code, 2147483650  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: improve ssl error code, 2147483650
List pgsql-hackers
On 25.06.24 16:21, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> On 21.06.24 16:53, Tom Lane wrote:
>>> Most of libpq gets at strerror_r via SOCK_STRERROR for Windows
>>> portability.  Is that relevant here?
> 
>> Looking inside the OpenSSL code, it makes no efforts to translate
>> between winsock error codes and standard error codes, so I don't think
>> our workaround/replacement code needs to do that either.
> 
> Fair enough.
> 
>> Btw., our source code comments say something like
>> "ERR_reason_error_string randomly refuses to map system errno values."
>> The reason it doesn't is exactly that it can't do it while maintaining
>> thread-safety.
> 
> Ah.  Do you want to improve that comment while you're at it?

Here is a patch that fixes the strerror() call and updates the comments 
a bit.

This ought to be backpatched like the original fix; ideally for the next 
minor releases in about two weeks.

Attachment

pgsql-hackers by date:

Previous
From: Jeremy Schneider
Date:
Subject: Re: [18] Policy on IMMUTABLE functions and Unicode updates
Next
From: Pavel Stehule
Date:
Subject: Re: Send duration output to separate log files