Re: BUG #6066: [PATCH] Mark more strings as c-format - Mailing list pgsql-bugs

From Alvaro Herrera
Subject Re: BUG #6066: [PATCH] Mark more strings as c-format
Date
Msg-id 1308320438-sup-7603@alvh.no-ip.org
Whole thread Raw
In response to Re: BUG #6066: [PATCH] Mark more strings as c-format  (Christoph Berg <cb@df7cb.de>)
List pgsql-bugs
Excerpts from Christoph Berg's message of vie jun 17 07:10:34 -0400 2011:
> Re: To pgsql-bugs@postgresql.org 2011-06-17 <20110617091114.GC4130@msgid.df7cb.de>
> > Unfortunately that doesn't help in this case, as the bad string isn't
> > tagged as "#, c-format", but still gets used as such. This seems to be
> > the case for many errhint() strings. Maybe xgettext should be taught
> > to treat all errhint() et al arguments as c-strings.
>
> Here's a patch to implement that, with backend/nls.mk updated.
>
> msgfmt -c is already available in the "maintainer-check-po" target.
> I'd assume this was called at least once during the release process.

Yeah, msgfmt -c is called pretty frequently on the translation service
http://babel.postgresql.org.

Thanks for the patch, I'll have a look at integrating it.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-bugs by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: BUG #6064: != NULL, <> NULL do not work
Next
From: Tom Lane
Date:
Subject: Re: BUG #6065: FATAL: lock 0 not held