Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64 - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64
Date
Msg-id 1303931274-sup-6567@alvh.no-ip.org
Whole thread Raw
In response to pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Excerpts from Tom Lane's message of lun abr 25 17:22:41 -0300 2011:
> Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.
>
> The expression that tried to round the value to the nearest TB could
> overflow, leading to bogus output as reported in bug #5993 from Nicola
> Cossu.  This isn't likely to ever happen in the intended usage of the
> function (if it could, we'd be needing to use a wider datatype instead);
> but it's not hard to give the expected output, so let's do so.

Apparently this change is causing Moa's SunStudio compiler to fail an
assertion.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Revert "Force use of "%I64d" format for 64 bit ints on MinGW."
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Fix binary upgrade of altered typed tables