pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64 - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64
Date
Msg-id E1QESIr-0002uh-BA@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-committers
Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.

The expression that tried to round the value to the nearest TB could
overflow, leading to bogus output as reported in bug #5993 from Nicola
Cossu.  This isn't likely to ever happen in the intended usage of the
function (if it could, we'd be needing to use a wider datatype instead);
but it's not hard to give the expected output, so let's do so.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/af0f20092c8662bf7610fab07b8a1e354abba67f

Modified Files
--------------
src/backend/utils/adt/dbsize.c |    8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64
Next
From: Robert Haas
Date:
Subject: pgsql: Remove partial and undocumented GRANT .. FOREIGN TABLE support.