Re: Determining client_encoding from client locale - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Determining client_encoding from client locale
Date
Msg-id 1295032362.29106.2.camel@vanquo.pezone.net
Whole thread Raw
In response to Re: Determining client_encoding from client locale  (Jaime Casanova <jcasanov@systemguards.com.ec>)
Responses Re: Determining client_encoding from client locale  (Susanne Ebrecht <susanne@2ndQuadrant.com>)
REVIEW: Determining client_encoding from client locale  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
On lör, 2009-07-25 at 01:41 -0500, Jaime Casanova wrote:
> On Fri, Jul 24, 2009 at 2:23 AM, Magnus Hagander<magnus@hagander.net> wrote:
> >>
> >> 1) it introduces a dependency for -lpgport when compiling a client
> >> that uses libpq
> >>    http://archives.postgresql.org/pgsql-hackers/2009-07/msg01511.php
> >
> > For other parts of libpgport that are needed, we pull in the
> > individual source files. We specifically *don't* link libpq with
> > libpgport, for a reason. There's a comment in the Makefile that
> > explains why.
> >
>
> ok, attached a version that modifies src/interfaces/libpq/Makefile to
> push chklocale.o and eliminate the dependency on libpgport, this
> change also fixes the compile problem on windows

I have adjusted your old patch for the current tree, and it seems to
work.  I think it was just forgotten last time because the move to
PQconnectdbParams had to happen first.  But I'll throw it back into the
ring now.

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: limiting hint bit I/O
Next
From: Robert Haas
Date:
Subject: Re: limiting hint bit I/O