Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.
Date
Msg-id 1295014817-sup-5347@alvh.no-ip.org
Whole thread Raw
In response to Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.  (Robert Haas <robertmhaas@gmail.com>)
Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
Excerpts from Robert Haas's message of vie ene 14 08:40:07 -0300 2011:

> Also, I don't really like the way this spreads knowledge of the
> completionTag out all over the backend.  I think it would be better to
> follow the existing model used by the COPY and COMMIT commands,
> whereby the return value indicates what happened and
> standard_ProcessUtility() uses that to set the command tag.

Yeah, that looks ugly.  However it's already ugly elsewhere: for example
see PerformPortalFetch.  I am not sure if it should be this patch's
responsability to clean that stuff up.  (Maybe we should decree that at
least this patch shouldn't make the situation worse.)

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Database file copy
Next
From: Alvaro Herrera
Date:
Subject: Re: Database file copy