Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.
Date
Msg-id 7606.1295024834@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.  (Simon Riggs <simon@2ndQuadrant.com>)
Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Robert Haas's message of vie ene 14 08:40:07 -0300 2011:
>> Also, I don't really like the way this spreads knowledge of the
>> completionTag out all over the backend.  I think it would be better to
>> follow the existing model used by the COPY and COMMIT commands,
>> whereby the return value indicates what happened and
>> standard_ProcessUtility() uses that to set the command tag.

> Yeah, that looks ugly.  However it's already ugly elsewhere: for example
> see PerformPortalFetch.  I am not sure if it should be this patch's
> responsability to clean that stuff up.  (Maybe we should decree that at
> least this patch shouldn't make the situation worse.)

I thought we were going to reject the patch outright anyway.  The
compatibility consequences of changing command tags are not worth the
benefit, independently of how ugly the backend-side code may or may
not be.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Error code for "terminating connection due to conflict with recovery"
Next
From: Simon Riggs
Date:
Subject: Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements.