Re: C++ keywords in headers (was Re: [GENERAL] #include ) - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: C++ keywords in headers (was Re: [GENERAL] #include )
Date
Msg-id 1293465256.11075.1.camel@vanquo.pezone.net
Whole thread Raw
In response to C++ keywords in headers (was Re: [GENERAL] #include )  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: C++ keywords in headers (was Re: [GENERAL] #include )
Re: C++ keywords in headers (was Re: [GENERAL] #include )
List pgsql-hackers
On sön, 2010-12-26 at 12:31 -0500, Tom Lane wrote:
> We did clean up C++ keyword uses in the header files in 9.0, but your
> report shows it's already gotten broken again.  I'm disinclined to fix
> it unless someone steps up to create an automated test that will get
> run reasonably often.  We had that discussion when the patch to rename
> keyword-named fields was proposed, and nothing got done, and the
> current state of affairs is the entirely predictable result.

src/tools/pginclude/cpluspluscheck

What's missing is to automate this, but it's unclear in what context,
and perhaps also to what extend this should be a hard requirement.



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Reduce lock levels for ADD and DROP COLUMN
Next
From: Magnus Hagander
Date:
Subject: Re: Streaming replication as a separate permissions